space/whisper-remote
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle CLI request errors and backend whisper timeout #3

Merged
luna merged 1 commits from fix/cli-network-errors-and-backend-timeout into main 2026-05-27 15:19:38 +02:00
Conversation 3 Commits 1 Files Changed 4 +67 -10
luna commented 2026-05-27 15:09:16 +02:00
Collaborator
Copy Link

Summary

  • handle httpx.RequestError in CLI with clean error messages instead of traceback dumps
  • add backend subprocess timeout for whisper CLI execution and map timeout to HTTP 504
  • add targeted tests for timeout/network-error formatting and timeout mapping

Validation

  • python3 -m py_compile cli/src/main.py backend/src/server.py cli/tests/test_main.py backend/tests/test_server.py

Notes

  • pytest is not installed in this environment, so full test execution was not possible here.
## Summary - handle httpx.RequestError in CLI with clean error messages instead of traceback dumps - add backend subprocess timeout for whisper CLI execution and map timeout to HTTP 504 - add targeted tests for timeout/network-error formatting and timeout mapping ## Validation - python3 -m py_compile cli/src/main.py backend/src/server.py cli/tests/test_main.py backend/tests/test_server.py ## Notes - pytest is not installed in this environment, so full test execution was not possible here.
luna added 1 commit 2026-05-27 15:09:16 +02:00
Handle CLI request errors and backend whisper timeout
Some checks failed
CI / Backend (pull_request) Failing after 15s
Details
CI / CLI (pull_request) Successful in 28s
Details
1c6415d306
luna commented 2026-05-27 15:16:47 +02:00
Author
Collaborator
Copy Link

@codex review

@codex review
gitea-codex commented 2026-05-27 15:16:55 +02:00
First-time contributor
Copy Link

👀 Codex review queued for commit 1c6415d.

👀 Codex review queued for commit `1c6415d`.
gitea-codex commented 2026-05-27 15:18:51 +02:00
First-time contributor
Copy Link

No blocking issues found in the introduced changes.

Scope reviewed:

  • backend/src/server.py
  • cli/src/main.py
  • associated tests in backend/tests/test_server.py and cli/tests/test_main.py

The new timeout/error-handling paths are coherent with existing behavior and are covered by targeted tests.

Note: model gpt-5.3-codex, input 45921, output 1212 tokens used.

ℹ️.codex-review.yml is not configured

<!-- codex-review:head_sha=1c6415d306abd5e4124929165112a9d0f0f7fb10 --> No blocking issues found in the introduced changes. Scope reviewed: - `backend/src/server.py` - `cli/src/main.py` - associated tests in `backend/tests/test_server.py` and `cli/tests/test_main.py` The new timeout/error-handling paths are coherent with existing behavior and are covered by targeted tests. _Note: model `gpt-5.3-codex`, input `45921`, output `1212` tokens used._ > ℹ️.codex-review.yml is not configured
luna merged commit 869a70b621 into main 2026-05-27 15:19:38 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
luna space
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: space/whisper-remote#3
Delete Branch "fix/cli-network-errors-and-backend-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?