space/jellomator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: verify Docker image build on pull requests #1

Merged
space merged 1 commits from chore/pr-docker-build-verify into main 2026-05-22 22:19:17 +02:00
Conversation 3 Commits 1 Files Changed 2 +23 -1
luna commented 2026-05-22 15:52:56 +02:00
Collaborator
Copy Link

Summary

  • add pull_request trigger for main in docker workflow
  • keep push workflow for publish, but skip publish job on PR events
  • add PR-only Docker build verification job (no push)
  • mark TODO item as completed

Verification

  • local docker build succeeded (image tag: jellomator:ci-check)
## Summary - add pull_request trigger for main in docker workflow - keep push workflow for publish, but skip publish job on PR events - add PR-only Docker build verification job (no push) - mark TODO item as completed ## Verification - local docker build succeeded (image tag: jellomator:ci-check)
luna added 1 commit 2026-05-22 15:52:56 +02:00
ci: verify Docker image build on pull requests
All checks were successful
docker / test (pull_request) Successful in 37s
Details
docker / build-and-push (pull_request) Has been skipped
Details
docker / build-verify-pr (pull_request) Successful in 40s
Details
1edb89884b
space commented 2026-05-22 21:19:23 +02:00
Owner
Copy Link

@codex review

@codex review
gitea-codex commented 2026-05-22 21:19:24 +02:00
First-time contributor
Copy Link

👀 Codex review queued for commit 1edb898.

👀 Codex review queued for commit `1edb898`.
gitea-codex commented 2026-05-22 21:19:47 +02:00
First-time contributor
Copy Link

Review Summary

I reviewed only the changes introduced by this PR, with focus on correctness, security, and maintainability.

What Changed

  • Added pull_request trigger for main (with same paths-ignore rules as push).
  • Prevented build-and-push from running on PRs via:
    • if: github.event_name != 'pull_request'
  • Added a PR-only build-verify-pr job that builds the Docker image with push: false.
  • Marked the related TODO item as completed.

Findings

No issues found that affect correctness, security, data integrity, or runtime behavior.

Verdict

Approved from a correctness/security perspective.

<!-- codex-review:head_sha=1edb89884bf8fa546ea89ab2088ec2c9dd7d58c2 --> ## Review Summary I reviewed only the changes introduced by this PR, with focus on correctness, security, and maintainability. ## What Changed - Added `pull_request` trigger for `main` (with same `paths-ignore` rules as push). - Prevented `build-and-push` from running on PRs via: - `if: github.event_name != 'pull_request'` - Added a PR-only `build-verify-pr` job that builds the Docker image with `push: false`. - Marked the related TODO item as completed. ## Findings No issues found that affect correctness, security, data integrity, or runtime behavior. ## Verdict Approved from a correctness/security perspective.
space merged commit 3969d3a0c6 into main 2026-05-22 22:19:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
luna space
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: space/jellomator#1
Delete Branch "chore/pr-docker-build-verify"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?