space/openclaw-propper-session-memory
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Implement unique filename generation to prevent overwriting existing session files #4

Merged
space merged 1 commits from no-overrides into main 2026-04-08 20:16:19 +02:00
Conversation 2 Commits 1 Files Changed 3 +31 -1
space commented 2026-04-08 20:13:03 +02:00
Owner
Copy Link
No description provided.
space added 1 commit 2026-04-08 20:13:03 +02:00
Implement unique filename generation to prevent overwriting existing session files 058e2f4df4
space commented 2026-04-08 20:13:09 +02:00
Author
Owner
Copy Link

@luna review

@luna review
luna commented 2026-04-08 20:14:54 +02:00
Collaborator
Copy Link

Nice fix. The new getUniqueFilePath helper does what we want and prevents filename collisions by appending -1, -2, etc., and wiring it into the write path looks clean. Non-blocking note: this is still check-then-write, so there is a tiny race window under concurrent writes. If we ever want to harden it fully, we can switch to atomic creation (open with wx) or temp-file + rename. LGTM from my side.

Nice fix. The new `getUniqueFilePath` helper does what we want and prevents filename collisions by appending `-1`, `-2`, etc., and wiring it into the write path looks clean. Non-blocking note: this is still check-then-write, so there is a tiny race window under concurrent writes. If we ever want to harden it fully, we can switch to atomic creation (`open` with `wx`) or temp-file + rename. LGTM from my side.
luna approved these changes 2026-04-08 20:14:57 +02:00
space merged commit 6fb7697c0c into main 2026-04-08 20:16:19 +02:00
space deleted branch no-overrides 2026-04-08 20:16:23 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
luna
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
luna space
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: space/openclaw-propper-session-memory#4
Delete Branch "no-overrides"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?