Fixed a few stupid mistakes

tests/test_dispatcher.py

@@ -2,7 +2,6 @@ from __future__ import annotations
 
 from types import SimpleNamespace
 
-import httpx
 from sqlalchemy import select
 
 from gitea_codex_bot.config import get_settings
@@ -15,7 +14,8 @@ from gitea_codex_bot.types import ParsedCommand
 from gitea_codex_bot.workers.dispatcher import process_one_job
 
 
-def test_process_one_job_recreates_persistent_comment_when_edit_returns_404(monkeypatch) -> None:
+def test_process_one_job_always_posts_new_review_comment(monkeypatch) -> None:
+    posted_ids: list[int] = []
     session_factory = get_session_factory()
     with session_factory() as session:
         job = enqueue_job(
@@ -39,37 +39,27 @@ def test_process_one_job_recreates_persistent_comment_when_edit_returns_404(monk
     monkeypatch.setattr(
         "gitea_codex_bot.workers.dispatcher.run_review_ephemeral",
         lambda *_args, **_kwargs: (
-            {
-                "verdict": "has_issues",
-                "confidence": 0.7,
-                "summary": "runner error",
-                "findings": [],
-            },
+            {"verdict": "has_issues", "confidence": 0.7, "summary": "runner error", "findings": []},
             RepoReviewConfig(configured=True, enabled=True),
         ),
     )
 
     class _FakeGiteaClient:
         def __init__(self, _settings) -> None:
-            self.posted_comment_id = 0
+            pass
 
         def get_pull_request(self, _repo: str, _pr_number: int):
             return SimpleNamespace(is_fork=False)
 
-        def edit_issue_comment(self, _repo: str, _comment_id: int, _body: str) -> int:
-            request = httpx.Request("PATCH", "https://gitea.test/api/v1/repos/acme/repo/issues/comments/289")
-            response = httpx.Response(404, request=request, text='{"message":"not found"}')
-            raise httpx.HTTPStatusError("not found", request=request, response=response)
-
         def post_issue_comment(self, _repo: str, _pr_number: int, _body: str) -> int:
-            self.posted_comment_id = 990
-            return self.posted_comment_id
+            new_id = 990
+            posted_ids.append(new_id)
+            return new_id
 
     monkeypatch.setattr("gitea_codex_bot.workers.dispatcher.GiteaClient", _FakeGiteaClient)
 
-    settings = get_settings()
-    processed = process_one_job(settings)
-    assert processed is True
+    assert process_one_job(get_settings()) is True
+    assert posted_ids == [990]
 
     with session_factory() as session:
         persisted_comment_id = get_persistent_review_comment_id(session, "acme/repo", 9)
@@ -107,15 +97,10 @@ def test_process_one_job_passes_full_trigger_message_to_runner(monkeypatch) -> N
         def post_issue_comment(self, _repo: str, _pr_number: int, _body: str) -> int:
             return 901
 
-        def edit_issue_comment(self, _repo: str, _comment_id: int, _body: str) -> int:
-            return _comment_id
-
     monkeypatch.setattr("gitea_codex_bot.workers.dispatcher.run_review_ephemeral", _fake_run_review_ephemeral)
     monkeypatch.setattr("gitea_codex_bot.workers.dispatcher.GiteaClient", _FakeGiteaClient)
 
-    settings = get_settings()
-    processed = process_one_job(settings)
-    assert processed is True
+    assert process_one_job(get_settings()) is True
     assert captured["raw"] == "@codex review security --full\nFocus auth/session handling."
 
 
@@ -155,9 +140,7 @@ def test_process_one_job_skips_review_when_repo_config_disabled(monkeypatch) ->
 
     monkeypatch.setattr("gitea_codex_bot.workers.dispatcher.GiteaClient", _FakeGiteaClient)
 
-    settings = get_settings()
-    processed = process_one_job(settings)
-    assert processed is True
+    assert process_one_job(get_settings()) is True
     assert any("Review is disabled" in body for body in posted_comments)
 
     with session_factory() as session: