luna/twitter-cli-cookiefile
1
0
Fork 0
Code Issues Pull Requests Actions Releases Activity

refactor: replace all RuntimeError with specific exception types

Browse Source 
- 5x RuntimeError → TwitterAPIError (create_tweet, fetch_me, quote_tweet, follow/unfollow)
- 2x RuntimeError(str(exc)) → bare raise (preserve original TwitterAPIError in _graphql_get/post)
This commit is contained in:
jackwener
2026-03-10 23:32:10 +08:00
parent c2b9be4669
commit f125d0fe7f
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
twitter_cli/client.py
View File

@@ -364,7 +364,7 @@ class TwitterClient:
result = _deep_get(data, "data", "create_tweet", "tweet_results", "result") result = _deep_get(data, "data", "create_tweet", "tweet_results", "result")
if result: if result:
return result.get("rest_id", "") return result.get("rest_id", "")
raise RuntimeError("Failed to create tweet") raise TwitterAPIError(0, "Failed to create tweet")
def delete_tweet(self, tweet_id): def delete_tweet(self, tweet_id):
# type: (str) -> bool # type: (str) -> bool
@@ -439,7 +439,7 @@ class TwitterClient:
profile_image_url=user_data.get("profile_image_url_https", ""), profile_image_url=user_data.get("profile_image_url_https", ""),
created_at=user_data.get("created_at", ""), created_at=user_data.get("created_at", ""),
) )
raise RuntimeError("Failed to fetch current user info") raise TwitterAPIError(0, "Failed to fetch current user info")
def quote_tweet(self, tweet_id, text): def quote_tweet(self, tweet_id, text):
# type: (str, str) -> str # type: (str, str) -> str
@@ -456,7 +456,7 @@ class TwitterClient:
result = _deep_get(data, "data", "create_tweet", "tweet_results", "result") result = _deep_get(data, "data", "create_tweet", "tweet_results", "result")
if result: if result:
return result.get("rest_id", "") return result.get("rest_id", "")
raise RuntimeError("Failed to create quote tweet") raise TwitterAPIError(0, "Failed to create quote tweet")
def follow_user(self, user_id): def follow_user(self, user_id):
# type: (str) -> bool # type: (str) -> bool
@@ -468,7 +468,7 @@ class TwitterClient:
session = _get_cffi_session() session = _get_cffi_session()
response = session.post(url, headers=headers, data=body, timeout=30) response = session.post(url, headers=headers, data=body, timeout=30)
if response.status_code >= 400: if response.status_code >= 400:
raise RuntimeError("Failed to follow user: HTTP %d" % response.status_code) raise TwitterAPIError(response.status_code, "Failed to follow user")
self._write_delay() self._write_delay()
return True return True
@@ -482,7 +482,7 @@ class TwitterClient:
session = _get_cffi_session() session = _get_cffi_session()
response = session.post(url, headers=headers, data=body, timeout=30) response = session.post(url, headers=headers, data=body, timeout=30)
if response.status_code >= 400: if response.status_code >= 400:
raise RuntimeError("Failed to unfollow user: HTTP %d" % response.status_code) raise TwitterAPIError(response.status_code, "Failed to unfollow user")
self._write_delay() self._write_delay()
return True return True
@@ -632,7 +632,7 @@ class TwitterClient:
refreshed_query_id = _resolve_query_id(operation_name, prefer_fallback=False, url_fetch_fn=_url_fetch) refreshed_query_id = _resolve_query_id(operation_name, prefer_fallback=False, url_fetch_fn=_url_fetch)
retry_url = _build_graphql_url(refreshed_query_id, operation_name, variables, features, field_toggles) retry_url = _build_graphql_url(refreshed_query_id, operation_name, variables, features, field_toggles)
return self._api_get(retry_url) return self._api_get(retry_url)
raise RuntimeError(str(exc)) raise
def _graphql_post(self, operation_name, variables, features=None): def _graphql_post(self, operation_name, variables, features=None):
# type: (str, Dict[str, Any], Optional[Dict[str, Any]]) -> Dict[str, Any] # type: (str, Dict[str, Any], Optional[Dict[str, Any]]) -> Dict[str, Any]
@@ -656,7 +656,7 @@ class TwitterClient:
_invalidate_query_id(operation_name) _invalidate_query_id(operation_name)
refreshed = _resolve_query_id(operation_name, prefer_fallback=False, url_fetch_fn=_url_fetch) refreshed = _resolve_query_id(operation_name, prefer_fallback=False, url_fetch_fn=_url_fetch)
return _do_post(refreshed) return _do_post(refreshed)
raise RuntimeError(str(exc)) raise
# ── Internal: HTTP request engine ──────────────────────────────── # ── Internal: HTTP request engine ────────────────────────────────