luna/twitter-cli-cookiefile
1
0
Fork 0
Code Issues Pull Requests Actions Releases Activity

fix: improve show handling, cache validation and tests

Browse Source 
Add extensive tests for the `show` command (happy path, empty/expired/malformed cache, out-of-range, zero/negative indices) and a test helper to write cache fixtures. Harden twitter_cli.cache._load_cache to validate payload types (dict/tweets list), filter non-dict entries, and treat malformed payloads as empty; also handle missing tweet id when resolving an index. Refactor CLI output logic by extracting _emit_tweet_detail and reuse it for both `tweet` and `show`; enforce 1-based indices for `show` via click.IntRange(1) and expand the "no cached results" error text to mention other list commands. These changes improve robustness against corrupted caches and increase test coverage for cache-based behavior.
This commit is contained in:
Pleasurecruise
2026-03-12 22:26:52 +00:00
parent 5335516d57
commit 72f62cedea
3 changed files with 123 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
twitter_cli/cli.py
View File

@@ -704,6 +704,12 @@ def tweet(ctx, tweet_id, max_count, full_text, as_json, as_yaml):
except RuntimeError as exc:
_exit_with_error(exc)
_emit_tweet_detail(tweets, compact=compact, as_json=as_json, as_yaml=as_yaml, full_text=full_text)
def _emit_tweet_detail(tweets, compact, as_json, as_yaml, full_text):
# type: (list, bool, bool, bool, bool) -> None
"""Render tweet detail + replies in the requested output format."""
if compact:
click.echo(tweets_to_compact_json(tweets))
return
@@ -720,7 +726,7 @@ def tweet(ctx, tweet_id, max_count, full_text, as_json, as_yaml):
@cli.command()
@click.argument("index", type=int)
@click.argument("index", type=click.IntRange(1))
@click.option("--max", "-n", "max_count", type=int, default=None, help="Max replies to fetch.")
@click.option("--full-text", is_flag=True, help="Show full reply text in table output.")
@structured_output_options
@@ -735,7 +741,8 @@ def show(ctx, index, max_count, full_text, as_json, as_yaml):
cache_size = get_cache_size()
if cache_size == 0:
raise click.UsageError(
"No cached results found. Run `twitter feed` or `twitter search` first."
"No cached results found. Run `twitter feed`, `twitter search`, "
"`twitter bookmarks`, or another list command first."
)
raise click.UsageError(
"Index %d is out of range (cache has %d tweets)." % (index, cache_size)
@@ -755,19 +762,7 @@ def show(ctx, index, max_count, full_text, as_json, as_yaml):
except RuntimeError as exc:
_exit_with_error(exc)
if compact:
click.echo(tweets_to_compact_json(tweets))
return
if emit_structured(tweets_to_data(tweets), as_json=as_json, as_yaml=as_yaml):
return
if tweets:
print_tweet_detail(tweets[0], console)
if len(tweets) > 1:
console.print("\n💬 Replies:")
print_tweet_table(tweets[1:], console, title="💬 Replies — %d" % (len(tweets) - 1), full_text=full_text)
console.print()
_emit_tweet_detail(tweets, compact=compact, as_json=as_json, as_yaml=as_yaml, full_text=full_text)
@cli.command()